[PATCH v3 1/3] net: emaclite: enable for more architectures

Michal Simek michal.simek at amd.com
Tue Oct 4 14:14:44 CEST 2022



On 9/27/22 13:21, samuel.obuch at codasip.com wrote:
> From: Samuel Obuch <samuel.obuch at codasip.com>
> 
> Function ioremap_nocache seems to be defined only for MIPS and Microblaze
> architectures. Therefore, the function call in the emaclite driver causes
> this driver to be unusable with other architectures, for example RISC-V.
> 
> Use ioremap function instead of ioremap_nocache, and include linux/io.h
> instead of asm/io.h, so that ioremap function is automatically created,
> if not defined by the architecture. We can switch to the ioremap function,
> as Microblaze's ioremap_nocache is just empty and in MIPS implementations
> of ioremap_nocache and ioremap are the same.
> 
> Signed-off-by: Samuel Obuch <samuel.obuch at codasip.com>
> ---
> 
> v3: Fix commit message, remove addtional asm/io.h include.
> 
> v2: Use ioremap instead of ioremap_nocache, switch to linux/io.h.
> 
> v1: Do not use ioremap_nocache for archs other than MIPS and Microblaze.
> 
>   drivers/net/xilinx_emaclite.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/xilinx_emaclite.c b/drivers/net/xilinx_emaclite.c
> index 6c9f1f7c27..29e8271c63 100644
> --- a/drivers/net/xilinx_emaclite.c
> +++ b/drivers/net/xilinx_emaclite.c
> @@ -14,14 +14,13 @@
>   #include <console.h>
>   #include <malloc.h>
>   #include <asm/global_data.h>
> -#include <asm/io.h>
>   #include <phy.h>
>   #include <miiphy.h>
>   #include <fdtdec.h>
>   #include <linux/delay.h>
>   #include <linux/errno.h>
> +#include <linux/io.h>
>   #include <linux/kernel.h>
> -#include <asm/io.h>
>   #include <eth_phy.h>
>   
>   DECLARE_GLOBAL_DATA_PTR;
> @@ -615,8 +614,8 @@ static int emaclite_of_to_plat(struct udevice *dev)
>   	int offset = 0;
>   
>   	pdata->iobase = dev_read_addr(dev);
> -	emaclite->regs = (struct emaclite_regs *)ioremap_nocache(pdata->iobase,
> -								 0x10000);
> +	emaclite->regs = (struct emaclite_regs *)ioremap(pdata->iobase,
> +							 0x10000);
>   
>   	emaclite->phyaddr = -1;
>   


Applied all.

Thanks,
Michal


More information about the U-Boot mailing list