[RFC PATCH 1/2] efi_loader: define internal implementations of install/uninstallmultiple
Ilias Apalodimas
ilias.apalodimas at linaro.org
Thu Oct 6 12:41:34 CEST 2022
Hi Heinrich
[...]
> > - return EFI_EXIT(EFI_INVALID_PARAMETER);
> > + return EFI_INVALID_PARAMETER;
>
> Please, use a efi_search_obj(handle) to determine if the handle is valid.
>
> if (!efi_search_obj(handle))
> return EFI_INVALID_PARAMETER;
We should only check against NULL here, since we need to add a new handle
if it doesn't exist. In Uninstall that would make sense, but we already
check that in efi_uninstall_protocol().
[...]
Thanks
/Ilias
More information about the U-Boot
mailing list