[PATCH 03/16] video: Use vidconsole_put_string() to write a string

Simon Glass sjg at chromium.org
Thu Oct 6 16:36:05 CEST 2022


Use the existing function rather that duplicating the code. Also fix up
the missing error handling.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

 drivers/video/vidconsole-uclass.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/video/vidconsole-uclass.c b/drivers/video/vidconsole-uclass.c
index 53263580e3b..d5667191e0a 100644
--- a/drivers/video/vidconsole-uclass.c
+++ b/drivers/video/vidconsole-uclass.c
@@ -652,17 +652,18 @@ static int do_video_puts(struct cmd_tbl *cmdtp, int flag, int argc,
 			 char *const argv[])
 {
 	struct udevice *dev;
-	const char *s;
+	int ret;
 
 	if (argc != 2)
 		return CMD_RET_USAGE;
 
 	if (uclass_first_device_err(UCLASS_VIDEO_CONSOLE, &dev))
 		return CMD_RET_FAILURE;
-	for (s = argv[1]; *s; s++)
-		vidconsole_put_char(dev, *s);
+	ret = vidconsole_put_string(dev, argv[1]);
+	if (!ret)
+		ret = video_sync(dev->parent, false);
 
-	return video_sync(dev->parent, false);
+	return ret ? CMD_RET_FAILURE : 0;
 }
 
 U_BOOT_CMD(
-- 
2.38.0.rc1.362.ged0d419d3c-goog



More information about the U-Boot mailing list