[PATCH 7/7] net/tftp: make tftpput working with servers that do not use OACK

Tom Rini trini at konsulko.com
Thu Oct 6 20:54:49 CEST 2022


On Thu, Oct 06, 2022 at 06:18:13AM +0300, mikhail.kshevetskiy at iopsys.eu wrote:

> From: Mikhail Kshevetskiy <mikhail.kshevetskiy at iopsys.eu>
> 
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy at iopsys.eu>
> ---
>  net/tftp.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/net/tftp.c b/net/tftp.c
> index dea9c25ffd..e120e4d766 100644
> --- a/net/tftp.c
> +++ b/net/tftp.c
> @@ -483,8 +483,15 @@ static void tftp_handler(uchar *pkt, unsigned dest, struct in_addr sip,
>  				tftp_prev_block = tftp_cur_block;
>  				tftp_cur_block = (unsigned short)(block + 1);
>  				update_block_number();
> -				if (ack_ok)
> +				if (ack_ok) {
> +					if (block == 0 &&
> +					    tftp_state == STATE_SEND_WRQ){
> +						/* connection's first ACK */
> +						tftp_state = STATE_DATA;
> +						tftp_remote_port = src;
> +					}
>  					tftp_send(); /* Send next data block */
> +				}
>  			}
>  		}
>  #endif

Can you please elaborate on how / when this would occur? Thanks.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20221006/f44be8f4/attachment.sig>


More information about the U-Boot mailing list