[PATCH] efi_driver: fix efi_uc_stop()

Ilias Apalodimas ilias.apalodimas at linaro.org
Sat Oct 8 08:52:10 CEST 2022


On Sat, 8 Oct 2022 at 00:55, Heinrich Schuchardt
<heinrich.schuchardt at canonical.com> wrote:
>
> We must always call EFI_EXIT() when returning from an EFIAPI function.
>
> Fixes: 05ef48a2484b ("efi_driver: EFI block driver")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> ---
>  lib/efi_driver/efi_uclass.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/lib/efi_driver/efi_uclass.c b/lib/efi_driver/efi_uclass.c
> index 6530f2daf6..45f9351988 100644
> --- a/lib/efi_driver/efi_uclass.c
> +++ b/lib/efi_driver/efi_uclass.c
> @@ -222,9 +222,10 @@ static efi_status_t EFIAPI efi_uc_stop(
>                         ret = disconnect_child(controller_handle,
>                                                child_handle_buffer[i]);
>                         if (ret != EFI_SUCCESS)
> -                               return ret;
> +                               goto out;
>                 }
> -               return EFI_SUCCESS;
> +               ret = EFI_SUCCESS;
> +                       goto out;
>         }
>
>         /* Destroy all children */
> --
> 2.37.2
>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>


More information about the U-Boot mailing list