[PATCH 2/2] buildman: Add --allow-missing-binaries flag to build with BINMAN_ALLOW_MISSING=1

Simon Glass sjg at chromium.org
Tue Oct 11 01:48:55 CEST 2022


Hi Tom,

On Mon, 10 Oct 2022 at 09:18, Tom Rini <trini at konsulko.com> wrote:
>
> Add a new flag to buildman so that we will in turn pass
> BINMAN_ALLOW_MISSING=1 to 'make'. Make use of this flag in CI.
>
> Cc: Rasmus Villemoes <rasmus.villemoes at prevas.dk>
> Cc: Simon Glass <sjg at chromium.org>
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
>  .azure-pipelines.yml            | 2 +-
>  .gitlab-ci.yml                  | 6 +++---
>  tools/buildman/builder.py       | 5 ++++-
>  tools/buildman/builderthread.py | 2 ++
>  tools/buildman/cmdline.py       | 3 +++
>  tools/buildman/control.py       | 3 ++-
>  6 files changed, 15 insertions(+), 6 deletions(-)
>
> diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml
> index f200b40dbb24..c932c2b3c619 100644
> --- a/.azure-pipelines.yml
> +++ b/.azure-pipelines.yml
> @@ -553,7 +553,7 @@ stages:
>            cat << "EOF" >> build.sh
>            if [[ "${BUILDMAN}" != "" ]]; then
>                ret=0;
> -              tools/buildman/buildman -o /tmp -P -E -W ${BUILDMAN} ${OVERRIDE} || ret=$?;
> +              tools/buildman/buildman -o /tmp -P -E -W --allow-missing-binaries ${BUILDMAN} ${OVERRIDE} || ret=$?;

This is fine for CI.

But having to provide a flag to do build testing seems like the tail
is wagging the dog. Boards should be discouraged to use blobs and we
don't want to make it hard for everyone else (who doesn't have the
blobs) to test whether their patch breaks a build.

Regards,
Simon


More information about the U-Boot mailing list