[PATCH 1/2] global: Do not default to faking missing binaries for buildman

[Simon Glass]

Hi Tom,

On Mon, 10 Oct 2022 at 09:18, Tom Rini <trini at konsulko.com> wrote:
>
> While it is possible and documented on how to re-run buildman to replace
> faked required binary files after the fact, this behavior ends up being
> more confusing than helpful in practice. Switch to requiring
> BINMAN_ALLOW_MISSING=1 to be passed on the 'make' line to enable this
> behavior.
>
> Cc: Rasmus Villemoes <rasmus.villemoes at prevas.dk>
> Cc: Simon Glass <sjg at chromium.org>
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 45f10759a137..535e52443ebf 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1345,8 +1345,8 @@ cmd_binman = $(srctree)/tools/binman/binman $(if $(BINMAN_DEBUG),-D) \
>                 $(foreach f,$(BINMAN_TOOLPATHS),--toolpath $(f)) \
>                  --toolpath $(objtree)/tools \
>                 $(if $(BINMAN_VERBOSE),-v$(BINMAN_VERBOSE)) \
> -               build -u -d u-boot.dtb -O . -m --allow-missing \
> -               --fake-ext-blobs \
> +               build -u -d u-boot.dtb -O . -m \
> +               $(if $(BINMAN_ALLOW_MISSING),--allow-missing --fake-ext-blobs) \
>                 -I . -I $(srctree) -I $(srctree)/board/$(BOARDDIR) \
>                 -I arch/$(ARCH)/dts -a of-list=$(CONFIG_OF_LIST) \
>                 $(foreach f,$(BINMAN_INDIRS),-I $(f)) \
> --
> 2.25.1
>

I'm not sure about this patch, but it might be good.

Basically the difference between this and the series I sent is that
here, binman is told to fail as soon as it sees a missing blob, rather
than finishing the image build and then failing.

So, for my approach, we get to see all the missing blobs and can
presumably deal with them together

With this approach, we need to do them one at a time, but a benefit is
that we do actually get that immediate failure and no messages about
missing or faked blobs.

There are pros and cons.

Regards,
Simon