[PATCH] xilinx: common: Add zynq_board_read_rom_ethaddr() declaration

[Michal Simek]

pá 7. 10. 2022 v 11:33 odesílatel Michal Simek <monstr at monstr.eu> napsal:
>
>
>
> On 10/4/22 07:46, Venkatesh Yadav Abbarapu wrote:
> > board.c defines zynq_board_read_rom_ethaddr(), but neglected to
> > include its declaration, causing the following sparse and
> > compile time warnings:
> >
> > board/xilinx/common/board.c:56:5:
> > warning: no previous prototype for 'zynq_board_read_rom_ethaddr'
> > [-Wmissing-prototypes]
> >
> > Include asm/arch/sys_proto.h, which includes the missing declaration.
> >
> > Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu at amd.com>
> > ---
> >
> >   board/xilinx/common/board.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/board/xilinx/common/board.c b/board/xilinx/common/board.c
> > index 9b4aded466..a822bcf53a 100644
> > --- a/board/xilinx/common/board.c
> > +++ b/board/xilinx/common/board.c
> > @@ -11,6 +11,7 @@
> >   #include <log.h>
> >   #include <asm/global_data.h>
> >   #include <asm/sections.h>
> > +#include <asm/arch/sys_proto.h>
> >   #include <dm/uclass.h>
> >   #include <i2c.h>
> >   #include <linux/sizes.h>
>

I have removed this patch from my queue because versal and versal-net
doesn't have this header that's why CI loop is failing.
I think it would be better to remove zynq_board_read_rom_ethaddr()
completely because none is using xlnx,eeprom anyway.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs