[PATCH v4 00/10] Use logging feature instead of FPGA_DEBUG

[Michal Simek]

On 10/7/22 14:19, Alexander Dahl wrote:
> Hei hei,
> 
> while working on FPGA support for a new device I discovered debug
> logging in some FPGA drivers is still done as in the old days.  Bring
> that to what I thougt would be the currently preferred approach.
> 
> Notes: Adding those Kconfig symbols in patch 1 is just to be able to
> build two of the old drivers.
> 
> All drivers touched were build tested with sandbox_defconfig and GCC 8
> on Debian GNU/Linux 10 (buster).
> 
> Lines with other possibly questionable output were not touched, only
> what seemed to be designated debug output, and only for FPGA drivers
> having that ancient FPGA_DEBUG / PRINTF macros, so there's room for
> future improvements.
> 
> Changelog:
> 
> v3 -> v4:
> - Reordered patches, Kconfig patch comes first now (made it easier to
>    build and test the series step by step)
> - Added three patches fixing printf compiler warnings first, before
>    changing to the new logging framework (so CI should not fail anymore
>    with -Werror)
> 
> v2 -> v3:
> - Patch introducing FPGA uclass was completely reworked, sent
>    independently from this series, and applied already, thus removed
> - Because requiring that new FPGA uclass changes, rebased on Michal's
>    microblaze branch '20221005'
> - Removed '"%s …", __func__' and '"%d …", __line__' from log messages,
>    because log framework can add those (enabled by CONFIG_LOGF_FUNC and
>    CONFIG_LOGF_LINE)
> 
> v1 -> v2:
> - Rebased on master
> - Added patch to introduce new FPGA uclass in front of the other patches
> - Use that new uclass as log category
> - Slightly reworded cover letter
> 
> Greets
> Alex
> 
> Cc: Michal Simek <michal.simek at amd.com>
> 
> Alexander Dahl (10):
>    fpga: Add missing Kconfig symbols for old FPGA drivers
>    fpga: spartan2: Fix printf arguments warning
>    fpga: spartan3: Fix printf arguments warning
>    fpga: virtex2: Fix printf format string warnings
>    fpga: altera: Use logging feature instead of FPGA_DEBUG
>    fpga: cyclon2: Use logging feature instead of FPGA_DEBUG
>    fpga: ACEX1K: Use logging feature instead of FPGA_DEBUG
>    fpga: spartan2: Use logging feature instead of FPGA_DEBUG
>    fpga: spartan3: Use logging feature instead of FPGA_DEBUG
>    fpga: virtex2: Use logging feature instead of FPGA_DEBUG
> 
>   drivers/fpga/ACEX1K.c   | 37 +++++++++----------
>   drivers/fpga/Kconfig    | 12 +++++++
>   drivers/fpga/altera.c   | 11 +++---
>   drivers/fpga/cyclon2.c  | 38 +++++++++-----------
>   drivers/fpga/spartan2.c | 80 +++++++++++++++++++----------------------
>   drivers/fpga/spartan3.c | 80 +++++++++++++++++++----------------------
>   drivers/fpga/virtex2.c  | 69 ++++++++++++++++-------------------
>   7 files changed, 152 insertions(+), 175 deletions(-)
> 
> 
> base-commit: 2d8cf392a77815f062446ef441f1078958dc1b2a

Applied.
M