[PATCH] Kconfig: distro: Use imply instead of select for CMD_FAT

[Simon Glass]

Hi Tom,

On Wed, 12 Oct 2022 at 06:50, Tom Rini <trini at konsulko.com> wrote:
>
> On Fri, Sep 02, 2022 at 11:28:49AM +0800, Jit Loon Lim wrote:
>
> > From: Tien Fong Chee <tien.fong.chee at intel.com>
> >
> > Using imply instead of select for CMD_FAT so overwritten is allowed in
> > later configuration.
> >
> > Signed-off-by: Tien Fong Chee <tien.fong.chee at intel.com>
> > ---
> >  Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Kconfig b/Kconfig
> > index 991b260182..71374980e9 100644
> > --- a/Kconfig
> > +++ b/Kconfig
> > @@ -201,7 +201,7 @@ config DISTRO_DEFAULTS
> >       select CMD_ENV_EXISTS
> >       select CMD_EXT2
> >       select CMD_EXT4
> > -     select CMD_FAT
> > +     imply CMD_FAT
> >       select CMD_FS_GENERIC
> >       select CMD_PART if PARTITIONS
> >       select CMD_PING if CMD_NET
>
> NAK, at least without explaining what the use case here is. A big part
> of generic distro work is "oh, you have that FAT32 ESP to use".

Isn't that just for EFI?

In general I try to use 'imply' so it is possible for a board to
disable the option.

Regards,
Simon