[PATCH] Kconfig: distro: Use imply instead of select for CMD_FAT

[Simon Glass]

Hi Tom,

On Wed, 12 Oct 2022 at 08:21, Tom Rini <trini at konsulko.com> wrote:
>
> On Wed, Oct 12, 2022 at 07:04:24AM -0600, Simon Glass wrote:
> > Hi Tom,
> >
> > On Wed, 12 Oct 2022 at 06:50, Tom Rini <trini at konsulko.com> wrote:
> > >
> > > On Fri, Sep 02, 2022 at 11:28:49AM +0800, Jit Loon Lim wrote:
> > >
> > > > From: Tien Fong Chee <tien.fong.chee at intel.com>
> > > >
> > > > Using imply instead of select for CMD_FAT so overwritten is allowed in
> > > > later configuration.
> > > >
> > > > Signed-off-by: Tien Fong Chee <tien.fong.chee at intel.com>
> > > > ---
> > > >  Kconfig | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/Kconfig b/Kconfig
> > > > index 991b260182..71374980e9 100644
> > > > --- a/Kconfig
> > > > +++ b/Kconfig
> > > > @@ -201,7 +201,7 @@ config DISTRO_DEFAULTS
> > > >       select CMD_ENV_EXISTS
> > > >       select CMD_EXT2
> > > >       select CMD_EXT4
> > > > -     select CMD_FAT
> > > > +     imply CMD_FAT
> > > >       select CMD_FS_GENERIC
> > > >       select CMD_PART if PARTITIONS
> > > >       select CMD_PING if CMD_NET
> > >
> > > NAK, at least without explaining what the use case here is. A big part
> > > of generic distro work is "oh, you have that FAT32 ESP to use".
> >
> > Isn't that just for EFI?
> >
> > In general I try to use 'imply' so it is possible for a board to
> > disable the option.
>
> Calling it an ESP? Yes. Expecting the first partition to be FAT? No,
> that's a forever-and-ever thing distros have been expecting on x86 and
> want to see everyone else do too (so their installer logic doesn't have
> to get further complex).

OK I See. Well, 'imply' is more friendly since it allows the choice,
if the function is not used. In fact 'DISTRO_DEFAULTS' is mostly
DISTRO_REQUIRED at this point :-)

Regards,
Simon