[PATCH v3 6/6] test: add test for eficonfig secure boot key management

[Simon Glass]

Hi Ilias,

On Fri, 14 Oct 2022 at 09:59, Ilias Apalodimas
<ilias.apalodimas at linaro.org> wrote:
>
> Hi Simon,
>
> On Fri, 14 Oct 2022 at 18:56, Simon Glass <sjg at chromium.org> wrote:
> >
> > Hi,
> >
> > On Fri, 14 Oct 2022 at 00:58, Masahisa Kojima
> > <masahisa.kojima at linaro.org> wrote:
> > >
> > > Provide a unit test for the eficonfig secure boot key
> > > management menu.
> > >
> > > Signed-off-by: Masahisa Kojima <masahisa.kojima at linaro.org>
> > > ---
> > > No change since v2
> > >
> > > newly created in v2
> > >
> > >  test/py/tests/test_eficonfig/conftest.py      |  84 +++-
> > >  test/py/tests/test_eficonfig/defs.py          |  14 +
> > >  .../test_eficonfig/test_eficonfig_sbkey.py    | 472 ++++++++++++++++++
> > >  3 files changed, 568 insertions(+), 2 deletions(-)
> > >  create mode 100644 test/py/tests/test_eficonfig/defs.py
> > >  create mode 100644 test/py/tests/test_eficonfig/test_eficonfig_sbkey.py
> >
> > Please can this test be in C? Also, using down-arrow to select menus
> > is brittle. Add a function to select the one you want, e.g. by name.
> >
>
> Is there a very specific reason why we should do stuff like that in C?

Yes, see here.

>  Python is way easier to extend and test in our case.

In what way? It seems a lot more complicated, plus the brittle nature
of this test suggests it will be a hassle to maintain.

https://u-boot.readthedocs.io/en/latest/develop/tests_writing.html#python-or-c

There is a pending update here too:

https://patchwork.ozlabs.org/project/uboot/patch/20221013122927.636867-15-sjg@chromium.org/

Regards,
SImon