[u-boot][PATCH 03/14] mtd: rawnand: omap_gpmc: Fix build warning on 64-bit platforms

Michael Nazzareno Trimarchi michael at amarulasolutions.com
Sat Oct 15 07:53:23 CEST 2022


On Tue, Oct 11, 2022 at 1:50 PM Roger Quadros <rogerq at kernel.org> wrote:
>
> Pointer size cannot be assumed to be 32-bit, so use
> use uintptr_t instead of uint32_t.
>
> Fixes the below build warning on 64-bit builds.
>
> drivers/mtd/nand/raw/omap_gpmc.c:439:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>   head = ((uint32_t) buf) % 4;
>
> Signed-off-by: Roger Quadros <rogerq at kernel.org>
> ---
>  drivers/mtd/nand/raw/omap_gpmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/omap_gpmc.c b/drivers/mtd/nand/raw/omap_gpmc.c
> index 7e9ccf7878..d62c3e6fce 100644
> --- a/drivers/mtd/nand/raw/omap_gpmc.c
> +++ b/drivers/mtd/nand/raw/omap_gpmc.c
> @@ -438,14 +438,14 @@ static inline void omap_nand_read(struct mtd_info *mtd, uint8_t *buf, int len)
>  static void omap_nand_read_prefetch(struct mtd_info *mtd, uint8_t *buf, int len)
>  {
>         int ret;
> -       uint32_t head, tail;
> +       uintptr_t head, tail;
>         struct nand_chip *chip = mtd_to_nand(mtd);
>
>         /*
>          * If the destination buffer is unaligned, start with reading
>          * the overlap byte-wise.
>          */
> -       head = ((uint32_t) buf) % 4;
> +       head = ((uintptr_t)buf) % 4;
>         if (head) {
>                 omap_nand_read(mtd, buf, head);
>                 buf += head;
> --
> 2.17.1
>

Reviewed-by: Michael Trimarchi <michael at amarulasolutions.com>

Michael

-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael at amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info at amarulasolutions.com
www.amarulasolutions.com


More information about the U-Boot mailing list