[PATCH v2 11/12] rockchip: lion-rk3368: migrate to u-boot-rockchip.bin

[Quentin Schulz]

Hi Kever,

On 10/21/22 03:14, Kever Yang wrote:
> 
> On 2022/10/19 22:10, quentin.schulz at theobroma-systems.com wrote:
>> Hi Kever,
>>
>> On 10/19/22 2:47 PM, Kever Yang <kever.yang at rock-chips.com> wrote:
>>> Hi Quentin,
>>>
>>>      This is report by the  denx ci system:
>>>
>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__source.denx.de_u-2Dboot_custodians_u-2Dboot-2Drockchip_-2D_jobs_515913&d=DwIDaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=jlsoDVbl-1nmumJr2buEbP1CHgfZWWOLR9Xh-ycxj-II1AQbLWozSLgCKBSYz-3o&s=dMfyQSyv3NY0elXedC3GxMELp8oSMp8hCy5WZniPV2U&e=
>>
>> I cannot see this page, probably a custodian account on that gitlab 
>> instance is required?
>>
>>>      And I can reproduce it with buildman sheep-rk3568
>>>
>>
>> I can reproduce by building for sheep-3368_defconfig indeed.
>>
>> CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR is not defined for this board 
>> and it is used in the lion dts.
>>
>> Since the Lion dts is built for any RK3368-based board, it needs to be 
>> defined for all boards based on RK3368 which is not the case for the 
>> Sheep board.
> 
> The lion dts is only used for this board, the sheep board have its own 
> dts, I didn't see any sheep dts include lion dts, but it's strange why 
> the sheep-rk3368 fail with lion change.
> 

It is not included, but all RK3368-based boards are compiled when 
CONFIG_ROCKCHIP_RK3368 is enabled, which is the case for all 
RK3368-based boards. SO if you compile U-Boot with sheep defconfig, you 
compile the device trees for other RK3368-based machines.

c.f.:
https://source.denx.de/u-boot/u-boot/-/blob/master/arch/arm/dts/Makefile#L131-L135

> 
>>
>> Was it a deliberate choice to build all DTS from a specific SoC, 
>> whatever the board you're building for?
>>
>> I would have imagined that using CONFIG_TARGET_LION_RK3368 instead of 
>> CONFIG_ROCKCHIP_RK3368 in arch/arm/dts/Makefile for deciding whether 
>> to build a device tree would make more sense?
>>
>> For the time being, please just drop this patch, we don't really need 
>> it at the moment so I'll have a look on how to do this properly when I 
>> have time.
> 
> OK, you  can send the follow up patch if we figure out the reason.
> 

My idea was to build those DTS based not on SoC-specific Kconfig but 
target-specific Kconfig, e.g. 
https://source.denx.de/u-boot/u-boot/-/blob/master/arch/arm/dts/Makefile#L3

I'll try to carve some time in the next few days/next week to do that.

Cheers,
Quentin