[PATCH v3 1/2] binman: bintool: remove btool_ prefix from btool names

Simon Glass sjg at chromium.org
Sat Oct 22 03:06:40 CEST 2022


Hi Quentin,

On Fri, 30 Sept 2022 at 17:49, Simon Glass <sjg at chromium.org> wrote:
>
> On Fri, 30 Sept 2022 at 08:37, Quentin Schulz <foss+uboot at 0leil.net> wrote:
> >
> > From: Quentin Schulz <quentin.schulz at theobroma-systems.com>
> >
> > The binary is looked on the system by the suffix of the packer class.
> > This means binman was looking for btool_gzip on the system and not gzip.
> >
> > Since a btool can have its btool_ prefix missing but its module and
> > binary presence on the system appropriately found, there's no need to
> > actually keep this prefix after listing all possible btools, so let's
> > remove it.
> >
> > This fixes gzip btool by letting Bintool.find_bintool_class handle the
> > missing prefix and still return the correct class which is then init
> > with gzip name instead of btool_gzip.
> >
> > Cc: Quentin Schulz <foss+uboot at 0leil.net>
> > Signed-off-by: Quentin Schulz <quentin.schulz at theobroma-systems.com>
> > ---
> >  tools/binman/bintool.py | 2 ++
> >  1 file changed, 2 insertions(+)
>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Unfortunately this breaks 'binman test'.

Regards,
Simon


More information about the U-Boot mailing list