[PATCH v3 1/2] x86: fsp: Depend on DM_RTC

[Stefan Roese]

On 24.10.22 18:49, Bin Meng wrote:
> On Mon, Oct 24, 2022 at 11:42 PM Sean Anderson <sean.anderson at seco.com> wrote:
>>
>> FSP support requires DM_RTC for rtc_write32. Select it.
>>
>> Fixes: ba65808e7d0 ("x86: fsp: Save stack address to CMOS for next S3 boot")
>> Signed-off-by: Sean Anderson <sean.anderson at seco.com>
>> ---
>> This seems like it would never have worked. Does fsp_save_s3_stack even
> 
> This was working before. Did you test it on x86 that now it is broken?
> 
> +Stefan

I don't have access to this FSP x86 target any more, so can't test
anything any more.

Thanks,
Stefan

>> get called in SPL? Maybe it should be converted to use dm_rtc_write
>> instead.
>>
>> Changes in v3:
>> - New
>>
>>   arch/x86/Kconfig | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>> index 7cbfd6c9720..ed8216d9ad0 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -362,6 +362,8 @@ config HAVE_FSP
>>          depends on !EFI
>>          select USE_HOB
>>          select HAS_ROM
>> +       select DM_RTC
>> +       select SPL_DM_RTC
>>          help
>>            Select this option to add an Firmware Support Package binary to
>>            the resulting U-Boot image. It is a binary blob which U-Boot uses
>> --
> 
> Regards,
> Bin

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de