[PATCH] Revert "pinctrl: zynqmp: Add support for output-enable and bias-high-impedance"

Michal Simek michal.simek at amd.com
Tue Oct 25 10:30:41 CEST 2022



On 10/13/22 13:05, Michal Simek wrote:
> This reverts commit 123462e5e534d6e17b1b7d2006734bbe54b03e0a.
> 
> On systems with older PMUFW using these pinctrl properties can cause system
> hang because there is missing feature autodetection.
> When it is implemented support for these two properties should go back.
> 
> Signed-off-by: Michal Simek <michal.simek at amd.com>
> ---
> 
> https://lore.kernel.org/all/9b7fac69-265e-52f2-21e4-83d9da0f257b@amd.com/
> ---
>   drivers/pinctrl/pinctrl-zynqmp.c | 9 ---------
>   1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-zynqmp.c b/drivers/pinctrl/pinctrl-zynqmp.c
> index 52d428f566fc..7c5a02db1b98 100644
> --- a/drivers/pinctrl/pinctrl-zynqmp.c
> +++ b/drivers/pinctrl/pinctrl-zynqmp.c
> @@ -467,10 +467,6 @@ static int zynqmp_pinconf_set(struct udevice *dev, unsigned int pin,
>   				 pin);
>   		break;
>   	case PIN_CONFIG_BIAS_HIGH_IMPEDANCE:
> -		param = PM_PINCTRL_CONFIG_TRI_STATE;
> -		arg = PM_PINCTRL_TRI_STATE_ENABLE;
> -		ret = zynqmp_pm_pinctrl_set_config(pin, param, arg);
> -		break;
>   	case PIN_CONFIG_LOW_POWER_MODE:
>   		/*
>   		 * This cases are mentioned in dts but configurable
> @@ -479,11 +475,6 @@ static int zynqmp_pinconf_set(struct udevice *dev, unsigned int pin,
>   		 */
>   		ret = 0;
>   		break;
> -	case PIN_CONFIG_OUTPUT_ENABLE:
> -		param = PM_PINCTRL_CONFIG_TRI_STATE;
> -		arg = PM_PINCTRL_TRI_STATE_DISABLE;
> -		ret = zynqmp_pm_pinctrl_set_config(pin, param, arg);
> -		break;
>   	default:
>   		dev_warn(dev, "unsupported configuration parameter '%u'\n",
>   			 param);

Applied.
M


More information about the U-Boot mailing list