[PATCH 2/4] usb: dwc3: reference clock period configuration

Marek Vasut marex at denx.de
Sun Oct 30 22:40:49 CET 2022


On 10/30/22 22:26, Sean Anderson wrote:

[...]

>> @@ -640,6 +663,9 @@ static int dwc3_core_init(struct dwc3 *dwc)
>>       /* Adjust Frame Length */
>>       dwc3_frame_length_adjustment(dwc, dwc->fladj);
>> +    /* Adjust Reference Clock Period */
>> +    dwc3_ref_clk_period(dwc);
>> +
>>       dwc3_set_incr_burst_type(dwc);
>>       return 0;
>> @@ -1043,6 +1069,7 @@ void dwc3_of_parse(struct dwc3 *dwc)
>>           | (dwc->is_utmi_l1_suspend << 4);
>>       dev_read_u32(dev, "snps,quirk-frame-length-adjustment", 
>> &dwc->fladj);
>> +    dev_read_u32(dev, "snps,ref-clock-period-ns", &dwc->ref_clk_per);
> 
> IMO we should skip support for this property since it is already 
> deprecated.

It is also still documented in the binding document and we get this 
support basically for free here. Deprecated properties should likely get 
filtered via dtbs_check for new DTs, for legacy DTs we can at least 
gracefully support them.


More information about the U-Boot mailing list