[PATCH v6 1/8] binman: add support for skipping file concatenation for mkimage

Simon Glass sjg at chromium.org
Thu Sep 1 20:44:19 CEST 2022


On Thu, 1 Sept 2022 at 10:39, Quentin Schulz <foss+uboot at 0leil.net> wrote:
>
> From: Quentin Schulz <quentin.schulz at theobroma-systems.com>
>
> Some image types handled by mkimage require the datafiles to be passed
> independently (-d data1:data2) for specific handling of each. A
> concatenation of datafiles prior to passing them to mkimage wouldn't
> work.
>
> That is the case for rkspi for example which requires page alignment
> and only writing 2KB every 4KB.
>
> This adds the ability to tell binman to pass the datafiles without
> prior concatenation to mkimage, by adding the multiple-data-files
> boolean property to the mkimage node.
>
> Cc: Quentin Schulz <foss+uboot at 0leil.net>
> Signed-off-by: Quentin Schulz <quentin.schulz at theobroma-systems.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>
> ---
>
> v6:
>  - added Rb,
>  - put tests at the end of the file,
>  - added test for multiple data files passed to mkimage with one data
>  file having no content (thanks Simon for the suggestion),
>  - added SPDX license to test files,
>  - renumbered test files,
>
> v5:
>  - changed to use full path from input dir with tools.get_input_filename
>  to make it possible to run the unit tests,
>  - added unit test,
>
>  tools/binman/entries.rst                      | 22 ++++++++++
>  tools/binman/etype/mkimage.py                 | 41 +++++++++++++++++--
>  tools/binman/ftest.py                         | 23 +++++++++++
>  tools/binman/test/252_mkimage_mult_data.dts   | 21 ++++++++++
>  .../test/253_mkimage_mult_no_content.dts      | 22 ++++++++++
>  5 files changed, 125 insertions(+), 4 deletions(-)
>  create mode 100644 tools/binman/test/252_mkimage_mult_data.dts
>  create mode 100644 tools/binman/test/253_mkimage_mult_no_content.dts


Reviewed-by: Simon Glass <sjg at chromium.org>
>
>


More information about the U-Boot mailing list