[PATCH 1/1] efi_loader: printing UEFI revision in helloworld.efi

[Simon Glass]

Hi Heinrich,

On Thu, 1 Sept 2022 at 19:09, Heinrich Schuchardt
<heinrich.schuchardt at canonical.com> wrote:
>
>
>
> On 9/2/22 01:52, Simon Glass wrote:
> > Hi Heinrich,
> >
> >
> > On Thu, 1 Sept 2022 at 14:44, Heinrich Schuchardt
> > <heinrich.schuchardt at canonical.com> wrote:
> >>
> >> We need to support multiple digits in the parts of the UEFI verision
> >> number. E.g.
> >>
> >>      EFI_SPECIFICATION_VERSION = (123 << 16) | 456
> >>
> >> must be printed as
> >>
> >>      123.45.6
> >>
> >> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> >> ---
> >>   lib/efi_loader/helloworld.c | 66 ++++++++++++++++++++++++++++++-------
> >>   1 file changed, 54 insertions(+), 12 deletions(-)
> >
> > Gosh, I'm not sure what to make of this! Could uint2dec() use strtoul()?
>
> This is standalone code. We cannot call any library functions here and
> we convert unsigned to wide string and not string to unsigned.

Oh well

Reviewed-by: Simon Glass <sjg at chromium.org>