[PATCH v1 1/6] watchdog: Integrate watchdog triggering into the cyclic framework

[Simon Glass]

Hi Stefan,

On Fri, 2 Sept 2022 at 06:11, Stefan Roese <sr at denx.de> wrote:
>
> This patch integrates the watchdog triggering into the recently added
> cyclic infrastructure. Each watchdog device that shall be triggered
> registers it's own cyclic function. This way, multiple watchdog devices
> are still supported, each via a cyclic function with separate trigger
> intervals.
>
> Signed-off-by: Stefan Roese <sr at denx.de>
> ---
> v1:
> - Reword WDT logging at startup as suggested by Rasmus
> - Fail upon !priv->cyclic initr_watchdog()
> - Remove some superflous checks in wdt_cyclic()
>
>  drivers/watchdog/Kconfig      |  2 +
>  drivers/watchdog/wdt-uclass.c | 73 ++++++++++++++++++++---------------
>  2 files changed, 43 insertions(+), 32 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

As a future enhancement, I think the cyclic handlers should return an
error code, which is retained somewhere, so it is possible to check
(perhaps on cmdline) whether there has been an error since the last
check.

Regards,
Simon