[PATCH v4 1/2] serial: mxc: enable the RX pipeline
Fabio Estevam
festevam at denx.de
Tue Sep 6 14:10:34 CEST 2022
Hi Johannes,
On 06/09/2022 09:06, Johannes Schneider wrote:
> +
> + /* setting the baudrate triggers a reset, returning cr3 to its
> + * reset value but UCR3_RXDMUXSEL "should always be set."
> + * according to the imx8 reference-manual
> + */
> + writel(readl(&base->cr3) | UCR3_RXDMUXSEL, &base->cr3);
> +
Nitpick: the recommended style for multi-line comments is:
/*
* Setting the baudrate triggers a reset, returning cr3 to its
* reset value but UCR3_RXDMUXSEL "should always be set."
* according to the imx8 reference-manual.
*/
Reviewed-by: Fabio Estevam <festevam at denx.de>
More information about the U-Boot
mailing list