[PATCH v2 1/1] cmd: fix tftpput command

Simon Glass sjg at chromium.org
Tue Sep 6 23:18:32 CEST 2022


Hi Heinrich,

On Sun, 4 Sept 2022 at 01:16, Heinrich Schuchardt
<heinrich.schuchardt at canonical.com> wrote:
>
> From: Heinrich Schuchardt <xypron.glpk at gmx.de>
>
> Calling tftpput with less than 2 arguments must lead to a failure.
>
> If tftpput is called with two arguments, these are the address and
> the size of the file to be transferred.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> ---
> v2:
>         carve out function parse_args()
> ---
>  cmd/net.c | 90 ++++++++++++++++++++++++++++++++++++++++---------------
>  1 file changed, 66 insertions(+), 24 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

If you can be bothered, this would be better as a refactoring commit
followed by a commit for your fix.

Regards,
Simon


More information about the U-Boot mailing list