[PATCH v2 4/4] test: cmd: add test for temperature command

[Robert Marko]

On Tue, Sep 6, 2022 at 11:18 PM Simon Glass <sjg at chromium.org> wrote:
>
> Hi Robert,
> H
> On Tue, 6 Sept 2022 at 04:50, Robert Marko <robert.marko at sartura.hr> wrote:
> >
> > On Sat, Sep 3, 2022 at 3:54 AM Tom Rini <trini at konsulko.com> wrote:
> > >
> > > On Fri, Aug 12, 2022 at 08:15:50PM +0200, Robert Marko wrote:
> > >
> > > > Add simple test for the temperature command.
> > > >
> > > > Signed-off-by: Robert Marko <robert.marko at sartura.hr>
> > > > Reviewed-by: Simon Glass <sjg at chromium.org>
> > > > ---
> > > >  test/cmd/Makefile      |  1 +
> > > >  test/cmd/temperature.c | 39 +++++++++++++++++++++++++++++++++++++++
> > > >  2 files changed, 40 insertions(+)
> > > >  create mode 100644 test/cmd/temperature.c
> > >
> > > This causes failures such as:
> > > https://source.denx.de/u-boot/u-boot/-/jobs/490586
> > > ---------------------------- Captured stdout setup -----------------------------
> > > /u-boot
> > > Creating new bloblist size 400 at c000
> > > Error binding driver 'thermal-sandbox': -96
> > > Some drivers failed to bind
> > > initcall sequence 0000560e11b023a0 failed at call 000000000005a8ef (err=-96)
> > > ### ERROR ### Please RESET the board ###
> >
> > Ok, so its failing on SPL and flattree/noninstall variants, but why is
> > the test even getting
> > executed if CONFIG_CMD_TEMPERATURE is not set in their defconfig-s?
>
> It looks like you are enabling CMD_TEMPERATURE for sandbox_flattree.
> Error -96 means the uclass is missing, so make sure that is built.
>
> For sandbox_spl the same applies. This is not about what happens in
> SPL itself, but what happens when sandbox SPL runs U-Boot proper.

Thanks,

I have sent a v3 yesterday that passes make check.

Regards,
Robert
>
> Regards,
> Simon



-- 
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko at sartura.hr
Web: www.sartura.hr