[PATCH v15 10/10] test: unit test for eficonfig

[Ilias Apalodimas]

Hi all,

On Thu, 8 Sept 2022 at 00:11, Simon Glass <sjg at chromium.org> wrote:
>
> Hi Masahisa,
>
> On Wed, 7 Sept 2022 at 00:13, Masahisa Kojima
> <masahisa.kojima at linaro.org> wrote:
> >
> > Hi Simon,
> >
> > On Wed, 7 Sept 2022 at 06:18, Simon Glass <sjg at chromium.org> wrote:
> > >
> > > Hi,
> > >
> > > On Fri, 2 Sept 2022 at 08:22, Masahisa Kojima
> > > <masahisa.kojima at linaro.org> wrote:
> > > >
> > > > Provide a unit test for the eficonfig command.
> > > >
> > > > Signed-off-by: Masahisa Kojima <masahisa.kojima at linaro.org>
> > > > Acked-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>
> > > > ---
> > > > No update since v15
> > > >
> > > > Changes in v14:
> > > > - update to support media device enumeration in eficonfig startup
> > > > - move no block device test to the last test case
> > > >
> > > > Changes in v12:
> > > > - update menu handling
> > > >
> > > > Changes in v11:
> > > > - fix expected result when no BootOrder is defined
> > > >
> > > > Newly added in v10
> > > >
> > > >  configs/sandbox_defconfig                     |   1 +
> > > >  test/py/tests/test_eficonfig/conftest.py      |  40 ++
> > > >  .../py/tests/test_eficonfig/test_eficonfig.py | 350 ++++++++++++++++++
> > > >  3 files changed, 391 insertions(+)
> > > >  create mode 100644 test/py/tests/test_eficonfig/conftest.py
> > > >  create mode 100644 test/py/tests/test_eficonfig/test_eficonfig.py
> > >
> > > How come this is written in Python? Shouldn't it be in C?
> >
> > Would you give more information why you prefer C to Python?
>
> Please see here:
>
> https://u-boot.readthedocs.io/en/latest/develop/tests_writing.html

I am not too familiar with all the testing facilities, but isn't
selecting menu items (which is what this is testing) easier to do in
python?
I assumed so since the bootmenu tests, which is what this command
using under the hood, are written in python

Regards
/Ilias
>
> Regards,
> Simon