[PATCH] doc: dm: Fix typo

Tom Rini trini at konsulko.com
Tue Sep 13 18:17:23 CEST 2022


On Tue, Sep 13, 2022 at 06:09:17PM +0200, Heinrich Schuchardt wrote:
> On 9/13/22 17:50, Tom Rini wrote:
> > On Tue, Sep 13, 2022 at 09:03:42AM -0400, Tom Rini wrote:
> > > On Tue, Sep 13, 2022 at 01:14:46PM +0200, Heinrich Schuchardt wrote:
> > > > On 9/13/22 12:51, Alexander Dahl wrote:
> > > > > That's most probably a typo, because driver model design documents seem
> > > > > to be from 2012 and there is no 2010.01 release.
> > > > > 
> > > > > Fixes: 282ed24fb3ca ("dm: MIGRATION: Add migration plan for CONFIG_DM")
> > > > > Signed-off-by: Alexander Dahl <ada at thorsis.com>
> > > > > ---
> > > > >    doc/develop/driver-model/migration.rst | 2 +-
> > > > >    1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > 
> > > > > diff --git a/doc/develop/driver-model/migration.rst b/doc/develop/driver-model/migration.rst
> > > > > index 5a60436925..cee38a56d0 100644
> > > > > --- a/doc/develop/driver-model/migration.rst
> > > > > +++ b/doc/develop/driver-model/migration.rst
> > > > > @@ -13,7 +13,7 @@ CONFIG_DM
> > > > >    * Status: In progress
> > > > >    * Deadline: 2020.01
> > > > > 
> > > > > -Starting with the 2010.01 release CONFIG_DM will be enabled for all boards.
> > > > > +Starting with the 2020.01 release CONFIG_DM will be enabled for all boards.
> > > > 
> > > > Thanks for pointing at the typo.
> > > > 
> > > > This migration is completed. Should we remove the entry from the list?
> > > 
> > > Should do a world build where the Makefile check is fatal first, and go
> > > from there.
> > 
> > OK, so I set up that kind of build on current master and it passes:
> > https://source.denx.de/u-boot/u-boot/-/pipelines/13433
> > 
> > Please do a patch to remove this section from
> > doc/develop/driver-model/migration.rst and drop the test in the Makefile
> > for CONFIG_DM being set as well. Thanks!
> > 
> 
> Should we change CONFIG_DM to be non-editable:
> 
>  config DM
> -       bool "Enable Driver Model"
> -       help
> -         This config option enables Driver Model. This brings in the core
> -         support, including scanning of platform data on start-up. If
> -         CONFIG_OF_CONTROL is enabled, the device tree will be scanned also
> -         when available.
> +       bool
> +       default y
> 
> And in the next step remove the symbol completely?

I wouldn't delete the help, but yes, it should also be def_bool y.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20220913/d7e4780f/attachment.sig>


More information about the U-Boot mailing list