[PATCH v1] net: nuvoton: fix build broken for use phy_get_interface_by_name

Ramon Fried rfried.dev at gmail.com
Sun Sep 18 08:07:34 CEST 2022


On Tue, Sep 13, 2022 at 9:25 AM Jim Liu <jim.t90615 at gmail.com> wrote:
>
> The original patch is use phy_get_interface_by_name to set interface.
> The new patch is use dev_read_phy_mode to replace it.
>
> Signed-off-by: Jim Liu <JJLIU0 at nuvoton.com>
> ---
>  drivers/net/npcm750_eth.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/npcm750_eth.c b/drivers/net/npcm750_eth.c
> index 409d5cce4a..bd29a10def 100644
> --- a/drivers/net/npcm750_eth.c
> +++ b/drivers/net/npcm750_eth.c
> @@ -710,12 +710,12 @@ static int npcm750_eth_ofdata_to_platdata(struct udevice *dev)
>
>         pdata->phy_interface = -1;
>         phy_mode = fdt_getprop(gd->fdt_blob, dev_of_offset(dev), "phy-mode", NULL);
> +
>         if (phy_mode)
> -               pdata->phy_interface = phy_get_interface_by_name(phy_mode);
> -       if (pdata->phy_interface == -1) {
> -               printf("%s: Invalid PHY interface '%s'\n", __func__, phy_mode);
> +               pdata->phy_interface = dev_read_phy_mode(dev);
> +
> +       if (pdata->phy_interface == PHY_INTERFACE_MODE_NA)
>                 return -EINVAL;
> -       }
>
>         pdata->max_speed = 0;
>         cell = fdt_getprop(gd->fdt_blob, dev_of_offset(dev), "max-speed", NULL);
> --
> 2.17.1
>
Reviewed-by: Ramon Fried <rfried.dev at gmail.com>


More information about the U-Boot mailing list