[PATCH] rockchip: puma-rk3399: remove dead code

Kever Yang kever.yang at rock-chips.com
Tue Sep 20 14:20:26 CEST 2022


On 2022/9/16 00:25, Quentin Schulz wrote:
> From: Quentin Schulz <quentin.schulz at theobroma-systems.com>
>
> CONFIG_SERIAL_TAG is not selectable for ARM64 machines. While
> get_board_serial is weakly defined if ENV_VARS_UBOOT_RUNTIME_CONFIG is
> defined, it is only called when CONFIG_SUPPORT_PASSING_ATAGS is defined,
> which also is not selectable for ARM64 machines. Therefore this is dead
> code so let's remove it.
>
> Cc: Quentin Schulz <foss+uboot at 0leil.net>
> Signed-off-by: Quentin Schulz <quentin.schulz at theobroma-systems.com>
Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever
> ---
>   .../theobroma-systems/puma_rk3399/puma-rk3399.c  | 16 ----------------
>   1 file changed, 16 deletions(-)
>
> diff --git a/board/theobroma-systems/puma_rk3399/puma-rk3399.c b/board/theobroma-systems/puma_rk3399/puma-rk3399.c
> index deeba3084a..3237a6aa2e 100644
> --- a/board/theobroma-systems/puma_rk3399/puma-rk3399.c
> +++ b/board/theobroma-systems/puma_rk3399/puma-rk3399.c
> @@ -136,19 +136,3 @@ int misc_init_r(void)
>   
>   	return 0;
>   }
> -
> -#ifdef CONFIG_SERIAL_TAG
> -void get_board_serial(struct tag_serialnr *serialnr)
> -{
> -	char *serial_string;
> -	u64 serial = 0;
> -
> -	serial_string = env_get("serial#");
> -
> -	if (serial_string)
> -		serial = simple_strtoull(serial_string, NULL, 16);
> -
> -	serialnr->high = (u32)(serial >> 32);
> -	serialnr->low = (u32)(serial & 0xffffffff);
> -}
> -#endif


More information about the U-Boot mailing list