[RFC][PATCH] spl: Turn spl_board_init() into weak symbol

Marek Vasut marex at denx.de
Tue Sep 20 17:56:50 CEST 2022


On 9/20/22 17:43, Simon Glass wrote:
> On Mon, 19 Sept 2022 at 21:52, Marek Vasut <marex at denx.de> wrote:
>>
>> Make spl_board_init() a weak symbol and get rid of Kconfig symbols
>> and ifdeffery guarding this function. Since the spl_board_init() is
>> now a weak symbol, boards can either use the default implementation
>> which is empty and gets inlined with zero text increase, or override
>> the implementation with their own as needed.
>>
>> Signed-off-by: Marek Vasut <marex at denx.de>
>> ---
>> Cc: Simon Glass <sjg at chromium.org>
>> Cc: Tom Rini <trini at konsulko.com>
>> ---
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> but please add a nice comment to spl_board_init() indicating what it
> is for and when it is called.

Actually, I wonder, should we start turning all the other symbols which 
are now protected by Kconfig symbol (the #ifdef CONFIG_FOO) into weak 
symbols without any need for Kconfig symbol guard instead as well?


More information about the U-Boot mailing list