[PATCH v2 0/8] Use logging feature instead of FPGA_DEBUG
Alexander Dahl
ada at thorsis.com
Wed Sep 21 15:22:08 CEST 2022
Hei hei,
while working on FPGA support for a new device I discovered debug
logging in some FPGA drivers is still done as in the old days. Bring
that to what I thougt would be the currently preferred approach.
Notes: Adding those Kconfig symbols in patch 4 is just to be able to
build those two old drivers.
All drivers touched were build tested with sandbox64_defconfig and GCC8
on Debian GNU/Linux 10 (buster).
Lines with other possibly questionable output were not touched, only
what seemed to be designated debug output, and only for FPGA drivers
having that ancient FPGA_DEBUG / PRINTF macros, so there's room for
future improvements.
Changelog:
v1 -> v2:
- Rebased on master
- Added patch to introduce new FPGA uclass in front of the other patches
- Use that new uclass as log category
- Slightly reworded cover letter
Greets
Alex
Alexander Dahl (8):
dm: fpga: Introduce new uclass
fpga: altera: Use logging feature instead of FPGA_DEBUG
fpga: cyclon2: Use logging feature instead of FPGA_DEBUG
fpga: Add missing Kconfig symbols for old FPGA drivers
fpga: ACEX1K: Use logging feature instead of FPGA_DEBUG
fpga: spartan2: Use logging feature instead of FPGA_DEBUG
fpga: spartan3: Use logging feature instead of FPGA_DEBUG
fpga: virtex2: Use logging feature instead of FPGA_DEBUG
drivers/fpga/ACEX1K.c | 22 +++++++++-------------
drivers/fpga/Kconfig | 12 ++++++++++++
drivers/fpga/altera.c | 13 ++++++-------
drivers/fpga/cyclon2.c | 24 ++++++++++--------------
drivers/fpga/spartan2.c | 34 +++++++++++++++-------------------
drivers/fpga/spartan3.c | 34 +++++++++++++++-------------------
drivers/fpga/virtex2.c | 37 +++++++++++++++----------------------
include/dm/uclass-id.h | 1 +
8 files changed, 83 insertions(+), 94 deletions(-)
base-commit: 12ed6d4911ced1df099a365e0a994b54211b60f3
--
2.30.2
More information about the U-Boot
mailing list