[PATCH 07/10] board_f/r: Allow selection of CONFIG_TIMER_EARLY w/o CONFIG_TIMER

Simon Glass sjg at chromium.org
Sun Sep 25 16:15:44 CEST 2022


Hi Stefan,

On Wed, 21 Sept 2022 at 08:06, Stefan Roese <sr at denx.de> wrote:
>
> The early timer functions provided via CONFIG_TIMER_EARLY don't need
> CONFIG_TIMER to be enabled, as they don't make use of the DM timer
> and uclass interface. This patch now allow the selection of
> CONFIG_TIMER_EARLY w/o CONFIG_TIMER, enabling this early timer
> functionality also for non CONFIG_TIMER drivers.
>
> With this change it's necessary to guard the dm_timer_init() call
> in initr_dm_devices() & initf_dm() additionally via CONFIG_TIMER.
>
> Signed-off-by: Stefan Roese <sr at denx.de>
> ---
>  common/board_f.c      | 2 +-
>  common/board_r.c      | 2 +-
>  drivers/timer/Kconfig | 1 -
>  3 files changed, 2 insertions(+), 3 deletions(-)

I don't like this as it complicates the logic and also seems to be
adding a new feature to legacy code.

Instead, let's enable the early timer only for driver model.

Regards,
Simon


More information about the U-Boot mailing list