[PATCH] watchdog: max6370: use __udelay() to avoid recursion

Stefan Roese sr at denx.de
Tue Sep 27 12:22:15 CEST 2022


On 27.09.22 12:19, Pali Rohár wrote:
> The udelay() function in lib/time.c contains a WATCHDOG_RESET()
> call. So use __udelay() in max6370_wdt.c to prevent recursion.
> 
> Fixes: 0a095fc53b15 ("watchdog: Add MAX6370 watchdog timer driver")
> Signed-off-by: Pali Rohár <pali at kernel.org>

Reviewed-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan

> ---
>   drivers/watchdog/max6370_wdt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/max6370_wdt.c b/drivers/watchdog/max6370_wdt.c
> index 556c6a4b6d6b..44872e23c586 100644
> --- a/drivers/watchdog/max6370_wdt.c
> +++ b/drivers/watchdog/max6370_wdt.c
> @@ -73,7 +73,7 @@ static int max6370_wdt_reset(struct udevice *dev)
>   
>   	if (dm_gpio_is_valid(&wdt->gpio_wdi)) {
>   		dm_gpio_set_value(&wdt->gpio_wdi, 1);
> -		udelay(1);
> +		__udelay(1);
>   		dm_gpio_set_value(&wdt->gpio_wdi, 0);
>   	} else {
>   		val = readb(wdt->reg);

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de


More information about the U-Boot mailing list