[PATCH] imx6: Remove extra quotes in fdtfile environment variable

Ariel D'Alessandro ariel.dalessandro at collabora.com
Tue Sep 27 16:23:34 CEST 2022


Hi Fabio,

On 9/27/22 11:20, Fabio Estevam wrote:
> Hi Ariel,
> 
> On Tue, Sep 27, 2022 at 11:14 AM Ariel D'Alessandro
> <ariel.dalessandro at collabora.com> wrote:
>>
>> After commit 395110284b56 ("nitrogen6x: Populate FDTFILE at build-time
>> for all platforms") iMX.6Q Sabrelite fails to boot due to a bad fdtfile
>> string:
>>
>>   Retrieving file: /dtbs/5.18.0-0.deb11.4-armmp/"imx6q-sabrelite".dtb
>>   ** File not found /dtbs/5.18.0-0.deb11.4-armmp/"imx6q-sabrelite".dtb **
>>
>> CONFIG_DEFAULT_DEVICE_TREE option is string typed, so __stringify() is
>> adding extra quotes. Remove this.
>>
>> Signed-off-by: Ariel D'Alessandro <ariel.dalessandro at collabora.com>
> 
> Just a nit: in the Subject, it would be better to change it like this:
> 
> nitrogen6x: Remove extra quotes in fdtfile

Makes sense. Will amend it right away.

> 
> Reviewed-by: Fabio Estevam <festevam at denx.de>
> 
> Stefano/Tom,
> 
> This is 2022.10 material IMHO.

Thanks!


More information about the U-Boot mailing list