[PATCH] tools: kwboot: Change KWBOOT_MSG_RSP_TIMEO_AXP to 10ms

Pali Rohár pali at kernel.org
Tue Sep 27 20:26:12 CEST 2022


On Friday 19 August 2022 10:20:46 Pali Rohár wrote:
> On Friday 19 August 2022 09:43:59 Stefan Roese wrote:
> > Testing on the theadorable Armada XP platform has shown, thaz using the
> > current value of 1000ms as response timeout does not result in reliable
> > booting via kwboot. Using 10ms seems to be much better. So let's change
> > this value to this 10ms instead.
> > 
> > Signed-off-by: Stefan Roese <sr at denx.de>
> 
> Acked-by: Pali Rohár <pali at kernel.org>

Hello Stefan! You should update also documentation file doc/kwboot.1
because it mention "1000 ms" for Option \fB-a\fP.

> > ---
> >  tools/kwboot.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/kwboot.c b/tools/kwboot.c
> > index 16bcd4d9a778..da4fe32da226 100644
> > --- a/tools/kwboot.c
> > +++ b/tools/kwboot.c
> > @@ -84,7 +84,7 @@ static unsigned char kwboot_msg_debug[] = {
> >  #define KWBOOT_MSG_RSP_TIMEO	50 /* ms */
> >  
> >  /* Defines known to work on Armada XP */
> > -#define KWBOOT_MSG_RSP_TIMEO_AXP	1000 /* ms */
> > +#define KWBOOT_MSG_RSP_TIMEO_AXP	10 /* ms */
> >  
> >  /*
> >   * Xmodem Transfers
> > -- 
> > 2.37.2
> > 


More information about the U-Boot mailing list