[PATCH v5 06/15] stdio: Fix class iteration in stdio_add_devices()

[Simon Glass]

Hi Michal,

On Tue, 27 Sept 2022 at 15:38, Michal Suchanek <msuchanek at suse.de> wrote:
>
> There is a complaint in the code that iterates keyboards that we don't
> have the _check variant of class iterator but we in fact do, use it.
>
> In the code that iterates video devices there is an attempt to print
> errors but the simple iterator does not return a device when there is an
> error. Use the _check variant of the iterator as well.
>
> Also print the symbolic error.

Again please drop this.

>
> Fixes: b206cd7372 ("dm: stdio: Plumb in the new keyboard uclass")
> Fixes: e3b81c1c0d ("dm: stdio: video: Plumb the video uclass into stdio")

I think overall you are a bit too zealous with your Fixes tags. The
comment was written in 2015 and the function you mention was added in
2017.

> Signed-off-by: Michal Suchanek <msuchanek at suse.de>
> ---
>  common/stdio.c | 33 ++++++++++++++-------------------
>  1 file changed, 14 insertions(+), 19 deletions(-)

With the above fixed:

Reviewed-by: Simon Glass <sjg at chromium.org>