[PATCH 1/1] efi_loader: fix efi_initrd_deregister()

Heinrich Schuchardt heinrich.schuchardt at canonical.com
Fri Sep 30 09:55:36 CEST 2022


On 9/30/22 09:29, Ilias Apalodimas wrote:
> Hi Heinrich
> 
> On Fri, 30 Sept 2022 at 10:18, Heinrich Schuchardt
> <heinrich.schuchardt at canonical.com> wrote:
>>
>> On 9/30/22 08:54, Ilias Apalodimas wrote:
>>> Akashi-san
>>>
>>> On Fri, 30 Sept 2022 at 09:41, AKASHI Takahiro
>>> <takahiro.akashi at linaro.org> wrote:
>>>>
>>>> Ilias,
>>>>
>>>> On Fri, Sep 30, 2022 at 09:18:35AM +0300, Ilias Apalodimas wrote:
>>>>> Akashi-san
>>>>>
>>>>> On Fri, 30 Sept 2022 at 04:47, AKASHI Takahiro
>>>>> <takahiro.akashi at linaro.org> wrote:
>>>>>>
>>>>>> On Fri, Sep 30, 2022 at 01:57:48AM +0200, Heinrich Schuchardt wrote:
>>>>>>> Don't try to delete a non-existent handle.
>>>>>>
>>>>>> It is okay as a safe guard, but it doesn't fix underlying issues.
>>>>>
>>>>> I dont think we safeguard anything. That code path won't try to delete
>>>>> anything regardless?
>>
>> I don't like to see a message
>>
>> "Can't remove invalid handle %p\n"
> 
> Fair enough.  Let's see if Akashi can clean up uninstalling the
> protocol, otherwise I am fine with this patch

Thanks Takahiro for looking into this.

For 2022.01 I will put this patch into a pull request to avoid 
irritating users by the message. For further changes it is too late in 
this cycle.

Best regards

Heinrich

> 
> Cheers
> /Ilias
>>
>> whenever I return from an EFI binary.
>>
>> Best regards
>>
>> Heinrich
>>
>>



More information about the U-Boot mailing list