[PATCH 1/1] sandbox: fix fall through in sandbox_flash_bulk()

Heinrich Schuchardt heinrich.schuchardt at canonical.com
Sat Apr 1 08:24:52 CEST 2023


Handling of SANDBOX_FLASH_EP_OUT should never fall through to
SANDBOX_FLASH_EP_IN.

This addresses a warning shown when compiling with
-Wimplicit-fallthrough.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
---
 drivers/usb/emul/sandbox_flash.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/emul/sandbox_flash.c b/drivers/usb/emul/sandbox_flash.c
index 01ccc4bc17..7c5c1ab3de 100644
--- a/drivers/usb/emul/sandbox_flash.c
+++ b/drivers/usb/emul/sandbox_flash.c
@@ -266,6 +266,7 @@ static int sandbox_flash_bulk(struct udevice *dev, struct usb_device *udev,
 		default:
 			break;
 		}
+		break;
 	case SANDBOX_FLASH_EP_IN:
 		switch (info->phase) {
 		case SCSIPH_DATA:
-- 
2.39.2



More information about the U-Boot mailing list