[PATCH 1/1] cmd: convert fallthrough comment.
Heinrich Schuchardt
heinrich.schuchardt at canonical.com
Sat Apr 1 09:14:11 CEST 2023
gcc does not understand /* FALL TROUGH */ and emits a warning:
cmd/date.c: In function ‘do_date’:
cmd/date.c:62:20: warning:
this statement may fall through [-Wimplicit-fallthrough=]
62 | if (strcmp(argv[1],"reset") == 0) {
| ^
cmd/date.c:102:9: note: here
102 | case 1: /* get date & time */
| ^~~~
Use the fallthrough macro instead.
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
---
cmd/date.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/date.c b/cmd/date.c
index 58505e6e1d..fe9c8c6534 100644
--- a/cmd/date.c
+++ b/cmd/date.c
@@ -98,7 +98,7 @@ static int do_date(struct cmd_tbl *cmdtp, int flag, int argc,
puts("## Get date failed\n");
}
}
- /* FALL TROUGH */
+ fallthrough;
case 1: /* get date & time */
#ifdef CONFIG_DM_RTC
rcode = dm_rtc_get(dev, &tm);
--
2.39.2
More information about the U-Boot
mailing list