[PATCH] Revert 9f62a472dfb2 ("video: Remove duplicate cursor-positioning function")

Tom Rini trini at konsulko.com
Sun Apr 2 16:32:55 CEST 2023


On Sun, Apr 02, 2023 at 05:22:52PM +1200, Simon Glass wrote:
> Hi Tom,
> 
> On Thu, 16 Mar 2023 at 05:01, Tom Rini <trini at konsulko.com> wrote:
> >
> > This reverts commit 9f62a472dfb26ec14408a27938ddd2a25700009d.
> >
> > The changes here aren't quite right, and on platforms such as Raspberry
> > Pi where we can have both serial and video output, the change above
> > causes output to change. This can be seen as the hush tests we have now
> > fail.
> 
> I took at look at sorting this out. I gave it a crack with:
> 
> CROSS_COMPILE=/home/sglass/.buildman-toolchains/gcc-7.3.0-nolibc/arm-linux-gnueabi/bin/arm-linux-gnueabi-
> ./test/py/test.py --bd rpi_3_32b --build-dir /tmp/b/rpi3  --build --id
> sjg-rpi_3b -k hush
> ================ 67 passed, 1 skipped, 322 deselected in 13.02s ================
> 
> Do you know which rpi and which test?

It was the if one about spaces, did you have video hooked up as well as
serial?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230402/6116a512/attachment.sig>


More information about the U-Boot mailing list