[PATCH v2] disk: Use a helper function to reduce duplication

Simon Glass sjg at chromium.org
Mon Apr 3 03:16:38 CEST 2023


Hi,

On Mon, 3 Apr 2023, 12:06 AKASHI Takahiro, <takahiro.akashi at linaro.org>
wrote:

> Hi Tom,
>
> On Fri, Mar 31, 2023 at 10:17:03AM -0400, Tom Rini wrote:
> > On Mon, Mar 20, 2023 at 08:29:57AM +1300, Simon Glass wrote:
> >
> > > Reduce the duplicated code slightly by using a helper function to
> handle
> > > the common code.
> > >
> > > This reduces the code size very slightly.
> > >
> > > Signed-off-by: Simon Glass <sjg at chromium.org>
> >
> > Applied to u-boot/next, thanks!
>
> I think I said nak against this patch.
> https://lists.denx.de/pipermail/u-boot/2023-March/512677.html


Yes,sorry I did'nt get back to it. If this applied I wonder if there is
test coverage missing. Do you think you could add a test for it?

I am afk so cannot send a revert for a few days,if someone else can?

Regards,
Simon

>
>
> -Takahiro Akashi
>
>
> > --
> > Tom
>
>
>


More information about the U-Boot mailing list