[PATCH 1/1] test: improve configuration for Kconfig test options

Heinrich Schuchardt heinrich.schuchardt at canonical.com
Mon Apr 3 12:04:39 CEST 2023


* Fix dependencies
* Provide labels that are easier to grasp.
* Fix typo %s/whgch/which/
* Fix type %s/Is/is/

Fixes: 29784d62eded ("test: Add some tests for kconfig.h")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
---
 test/lib/Kconfig | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/test/lib/Kconfig b/test/lib/Kconfig
index dbb03e4a36..ae0aa2ff7a 100644
--- a/test/lib/Kconfig
+++ b/test/lib/Kconfig
@@ -1,23 +1,24 @@
 # SPDX-License-Identifier: GPL-2.0+
 # Copyright 2022 Google LLC
 
-if SANDBOX
-
 config TEST_KCONFIG
 	bool "Enable detection of Kconfig macro errors"
+	depends on SANDBOX
 	help
 	  This is used to test that the IF_ENABLED_INT() macro causes a build error
-	  if the value is used when the CONFIG Is not enabled.
+	  if the value is used when the CONFIG is not enabled.
+
+if TEST_KCONFIG
 
 config TEST_KCONFIG_ENABLE
-	bool "Option to enable"
+	bool "Provide a value for the Kconfig test"
 	help
 	  This is the option that controls whether the value is present.
 
 config TEST_KCONFIG_VALUE
-	int "Value associated with the option"
+	int "Value used in Kconfig test"
 	depends on TEST_KCONFIG_ENABLE
 	help
-	  This is the value whgch is present if TEST_KCONFIG_ENABLE is enabled.
+	  This is the value which is present if TEST_KCONFIG_ENABLE is enabled.
 
-endif # SANDBOX
+endif # TEST_KCONFIG
-- 
2.39.2



More information about the U-Boot mailing list