[PATCH v3 2/2] spl: mmc: Pass eMMC HW partition 7 through

[Marek Vasut]

On 4/5/23 00:44, Pali Rohár wrote:
> On Wednesday 05 April 2023 00:33:02 Marek Vasut wrote:
>> On 4/5/23 00:16, Pali Rohár wrote:
>>> On Wednesday 05 April 2023 00:11:17 Marek Vasut wrote:
>>>> On 4/4/23 21:25, Pali Rohár wrote:
>>>>> On Tuesday 04 April 2023 20:05:15 Marek Vasut wrote:
>>>>>> The eMMC HW partition 0 and 7 both mean USER HW partition.
>>>>>
>>>>> This is not truth!
>>>>
>>>> Can you please provide further details to back your claim ?
>>>
>>> Yes, see a patch with explanation which I meanwhile sent:
>>> https://patchwork.ozlabs.org/project/uboot/patch/20230404202805.8523-1-pali@kernel.org/
>>
>> This very much adds a comment that looks like the content of the second
>> paragraph of my reply, see below.
>>
>> It is a good thing you mention the aforementioned patch, since exactly one
>> line past the changes you implemented is the following piece of code:
>>
>> https://source.denx.de/u-boot/u-boot/-/blob/master/common/spl/spl_mmc.c#L382
>>
>> "
>> int default_spl_mmc_emmc_boot_partition(struct mmc *mmc)
>> ...
>> part = (mmc->part_config >> 3) & PART_ACCESS_MASK;
>> if (part == 7)
>>      part = 0;
>> "
>>
>> Which maps 7 to 0 .
>>
>>>> This kind of screaming feedback with zero additional information is
>>>> worthless, sorry. Before you proceed with any further replies, please have a
>>>> look at JEDEC JESD84-B51 section 7.4.69 PARTITION_CONFIG Bit[5:3]
>>>> BOOT_PARTITION_ENABLE , this is what is being discussed here. Value 1/2 is
>>>> either BOOT HW partition, value 0/7 is treated as USER HW partition by the
>>>> boot code.
>>
>> Please read the paragraph above, I do not see any reply to it and I think
>> that might put the conversation back on track.
> 
> I have read it and the reply with explanation is already there in my
> first email and also in the linked email.
> 
> What you have written above in not truth.

Very well, I think I will defer further judgement to the MMC maintainer 
and stop participating in this thread. Constructive feedback is welcome.