[PATCH v2 00/18] Migration to using binman to generate

[Neha Malcom Francis]

Hi Andrew,

On 05/04/23 00:27, Andrew Davis wrote:
> On 4/4/23 7:13 AM, Neha Malcom Francis wrote:
>> This series aims to eliminate the use of additional custom repositories
>> such as k3-image-gen (K3 Image Generation) repo that was plumbed into
>> the U-Boot build flow to generate boot images for TI K3 platform devices.
>> And instead, we move towards using binman that aligns better with the
>> community standard build flow.
>>
>> This series uses binman for all K3 platforms supported on U-Boot 
>> currently;
>> both HS (High Security) and GP (General Purpose) devices.
>>
>> Background on using k3-image-gen:
>>     * TI K3 devices require a SYSFW (System Firmware) image consisting
>>     of a signed system firmware image and board configuration binaries,
>>     this is needed to bring up system firmware during U-Boot R5 SPL
>>     startup.
>>     * Board configuration data contain board-specific information
>>     such as resource management, power management and security.
>>
>> Series intends to use binman to take over the packaging and signing for
>> the R5 bootloader images tiboot3.bin (and sysfw.itb, for non-combined
>> boot flow) instead of k3-image-gen.
>>
>> Series also packages the A72/A53 bootloader images (tispl.bin and
>> u-boot.img) using ATF, OPTEE and DM (Device Manager)
>>
>> Changes in v2:
>>     - removed all external scripts
>>     - created ti-board-config etype to support generation of board
>>       config binaries
>>     - created ti-secure and ti-secure-rom etypes to handle signing
>>       instead of using external TI_SECURE_DEV_PKG
>>     - updated openssl btool to support x509 certificate generation
>>     - dropped Makefile changes to obtain external binary components,
>>       moving to using BINMAN_INDIRS to achieve the same
>>
> 
> Another thing that got changed is you seem to have dropped the 
> documentation
> update patch from v1. The documentation change is the best part as it shows
> how much easier this series makes building U-Boot for K3! :)
> 

My bad, I didn't realize that had slipped out while sending v2, I will 
be sure to add it when sending the next version.

> I did notice a build error when trying this with am62x_evm_r5_defconfig. I
> don't think this series caused the issue, but it does expose the issue. Fix
> sent here[0]. So if anyone has issues building this series try that patch.
> 

Thank you for noticing, I had included types.h while building and 
excluded it later, this patch should fix it. Thanks for the patch!

> Other than the couple minor comments, everything looks good and I'm 
> extremely
> impressed how well this all turned out. Removing the external tooling 
> and scripts
> previously needed to build U-Boot for K3 is key to our upstream-first 
> goals and
> long term support strategy.
> 
> Thank you!
> 
> For the whole series,
> 
> Acked-by: Andrew Davis <afd at ti.com>
> 
> [0] https://lists.denx.de/pipermail/u-boot/2023-April/514400.html

-- 
Thanking You
Neha Malcom Francis