[PATCH v2 10/12] arm: mach-k3: Move sdelay() and wait_on_value() declaration

[Christian Gmeiner]

>
> These probably should be in some system wide header given their use.
> Until then move them out of K3 sys_proto.h so we can finish cleaning
> that header out.
>

If I grep for wait_on_value there are other sys_proto.h files like the one from
arch-omap3, arch-omap4, arch-am33xx,.. that have this declaration in
sys_proto.k.

Do we really want that change? What is the plan for other arch's?

Do not take this a strong no as I am only doing some drive-by
comments. With that sayed you
can add my Rb.

> Signed-off-by: Andrew Davis <afd at ti.com>
> ---
>  arch/arm/mach-k3/include/mach/sys_proto.h | 4 ----
>  drivers/ram/k3-am654-ddrss.c              | 4 ++++
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-k3/include/mach/sys_proto.h b/arch/arm/mach-k3/include/mach/sys_proto.h
> index bbe57718e1a..4b4e2a5be39 100644
> --- a/arch/arm/mach-k3/include/mach/sys_proto.h
> +++ b/arch/arm/mach-k3/include/mach/sys_proto.h
> @@ -7,10 +7,6 @@
>  #ifndef _SYS_PROTO_H_
>  #define _SYS_PROTO_H_
>
> -void sdelay(unsigned long loops);
> -u32 wait_on_value(u32 read_bit_mask, u32 match_value, void *read_addr,
> -                 u32 bound);
> -
>  void k3_spl_init(void);
>  void k3_mem_init(void);
>  bool check_rom_loaded_sysfw(void);
> diff --git a/drivers/ram/k3-am654-ddrss.c b/drivers/ram/k3-am654-ddrss.c
> index 4453c247b29..adac14f9464 100644
> --- a/drivers/ram/k3-am654-ddrss.c
> +++ b/drivers/ram/k3-am654-ddrss.c
> @@ -18,6 +18,10 @@
>  #include <power/regulator.h>
>  #include "k3-am654-ddrss.h"
>
> +void sdelay(unsigned long loops);
> +u32 wait_on_value(u32 read_bit_mask, u32 match_value, void *read_addr,
> +                 u32 bound);
> +
>  #define LDELAY 10000
>
>  /* DDRSS PHY configuration register fixed values */
> --
> 2.39.2
>


-- 
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info/privacypolicy