[PATCH v2 1/4] sunxi: spl: Disable padding from SPL_PAD_TO

Andre Przywara andre.przywara at arm.com
Thu Apr 6 17:42:03 CEST 2023


On Sun, 22 Jan 2023 15:15:27 -0600
Samuel Holland <samuel at sholland.org> wrote:

Hi Samuel,

> Starting with H6, Allwinner removed the artificial 32 KiB SPL size limit
> from the boot ROM. Now SPL size is only limited by the available SRAM.
> This limit ranges from 152 KiB on H6 to a whopping 2052 KiB on R329. To
> take advantage of this additional space, we must increase SPL_MAX_SIZE.
> Since we do not want to unnecessarily pad SPL out to these giant sizes,
> we must set SPL_PAD_TO to zero. This causes no problems because binman
> already takes care of appending the SPL payload at the right offset.

So this patch breaks compilation, unless we have CONFIG_SPL_LOAD_FIT=1.
Since this becomes only possible for ARM32 at the end of the series, this
would need to move there, at the very least.
But then it still would break if someone de-selects this option (it's
"imply" only).
I don't have time at the moment to deep dive into this, if someone has an
idea how to fix this without forcing SPL_LOAD_FIT, I am all ears.

Cheers,
Andre

> Signed-off-by: Samuel Holland <samuel at sholland.org>
> ---
> 
> Changes in v2:
>  - New patch for v2
> 
>  common/spl/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> index 3c2af453ab..a7c55f8c4c 100644
> --- a/common/spl/Kconfig
> +++ b/common/spl/Kconfig
> @@ -97,8 +97,7 @@ config SPL_PAD_TO
>  	default 0x31000 if ARCH_MX6 && MX6_OCRAM_256KB
>  	default 0x11000 if ARCH_MX7 || (ARCH_MX6 && !MX6_OCRAM_256KB)
>  	default 0x10000 if ARCH_KEYSTONE
> -	default 0x8000 if ARCH_SUNXI && !MACH_SUN50I_H616
> -	default 0x0 if ARCH_MTMIPS
> +	default 0x0 if ARCH_MTMIPS || ARCH_SUNXI
>  	default TPL_MAX_SIZE if TPL_MAX_SIZE > SPL_MAX_SIZE
>  	default SPL_MAX_SIZE
>  	help



More information about the U-Boot mailing list