[BUG] issues with new bootflow, uefi and virtio

[Simon Glass]

Hi Vincent,

On Thu, 6 Apr 2023 at 22:05, Vincent Stehlé <vincent.stehle at arm.com> wrote:
>
> On Thu, Apr 06, 2023 at 06:38:16AM +1200, Simon Glass wrote:
> (virtio device number 31 vs. blk index 0)
> > This is strange. Can you try 'dm uclass' to see the sequence number
> > for the virtio device? I would expect it to be 0, but I might not
> > fully understand virtio.
>
> Hi Simon,
>
> Thank you for looking into this. Here is the `dm uclass' extract corresponding
> to virtio on this Qemu system:
>
>   uclass 126: virtio
>   0   * virtio_mmio at a000000 @ 7ee977d0, seq 0
>   1   * virtio_mmio at a000200 @ 7ee97870, seq 1
>   2   * virtio_mmio at a000400 @ 7ee97910, seq 2
>   3   * virtio_mmio at a000600 @ 7ee979b0, seq 3
>   4   * virtio_mmio at a000800 @ 7ee97a50, seq 4
>   5   * virtio_mmio at a000a00 @ 7ee97af0, seq 5
>   6   * virtio_mmio at a000c00 @ 7ee97b90, seq 6
>   7   * virtio_mmio at a000e00 @ 7ee97c30, seq 7
>   8   * virtio_mmio at a001000 @ 7ee97cd0, seq 8
>   9   * virtio_mmio at a001200 @ 7ee97d70, seq 9
>   10  * virtio_mmio at a001400 @ 7ee97e10, seq 10
>   11  * virtio_mmio at a001600 @ 7ee97eb0, seq 11
>   12  * virtio_mmio at a001800 @ 7ee97f50, seq 12
>   13  * virtio_mmio at a001a00 @ 7ee97ff0, seq 13
>   14  * virtio_mmio at a001c00 @ 7ee98090, seq 14
>   15  * virtio_mmio at a001e00 @ 7ee98130, seq 15
>   16  * virtio_mmio at a002000 @ 7ee981d0, seq 16
>   17  * virtio_mmio at a002200 @ 7ee98270, seq 17
>   18  * virtio_mmio at a002400 @ 7ee98310, seq 18
>   19  * virtio_mmio at a002600 @ 7ee983b0, seq 19
>   20  * virtio_mmio at a002800 @ 7ee98450, seq 20
>   21  * virtio_mmio at a002a00 @ 7ee984f0, seq 21
>   22  * virtio_mmio at a002c00 @ 7ee98590, seq 22
>   23  * virtio_mmio at a002e00 @ 7ee98630, seq 23
>   24  * virtio_mmio at a003000 @ 7ee986d0, seq 24
>   25  * virtio_mmio at a003200 @ 7ee98770, seq 25
>   26  * virtio_mmio at a003400 @ 7ee98810, seq 26
>   27  * virtio_mmio at a003600 @ 7ee988b0, seq 27
>   28  * virtio_mmio at a003800 @ 7ee98950, seq 28
>   29  * virtio_mmio at a003a00 @ 7ee989f0, seq 29
>   30  * virtio_mmio at a003c00 @ 7ee98a90, seq 30
>   31  * virtio_mmio at a003e00 @ 7ee98b30, seq 31
>
> (issue with multiple virtio devices)

OK, thanks for that. I had no idea there would be lots of them.

> > Please also see this:
> >
> > https://patchwork.ozlabs.org/project/uboot/patch/20230402140231.v7.3.Ifa423a8f295b3c11e50821222b0db1e869d0c051@changeid/
> >
> > (or the whole series)
>
> Thank you for this patch!
>
> When combined with the patch from Mathew[1], it does indeed repair the case of
> efi boot with two virtio disks, specifically when the first virtio disk is the
> one we want to boot from.
> FWIW, the system will not boot when I invert the two virtio disks.

Is this because it only uses the first virtio device? You could check
your boot_targets variable. With standard boot you can use 'virtio'
instead of 'vritio0' and it will find any virtio devices.

>
> Best regards,
> Vincent.
>
> [1]: https://lists.denx.de/pipermail/u-boot/2023-April/514527.html

Regards,
Simon