[PATCH 1/1] pytest: Use --lazy with umount

Tom Rini trini at konsulko.com
Fri Apr 7 21:46:08 CEST 2023


On Sat, Apr 08, 2023 at 06:55:14AM +1200, Simon Glass wrote:
> Hi Tom,
> 
> On Sat, 8 Apr 2023 at 02:36, Tom Rini <trini at konsulko.com> wrote:
> >
> > On Fri, Apr 07, 2023 at 05:31:17PM +1200, Simon Glass wrote:
> > > Hi Tom,
> > >
> > > On Thu, 6 Apr 2023 at 14:19, Tom Rini <trini at konsulko.com> wrote:
> > > >
> > > > Sometimes when doing tests on real hardware we sometimes run in to the
> > > > case where some of these mounts haven't been fully flushed.  Using the
> > > > --lazy option with umount will allow us to continue while letting the OS
> > > > handle flushing the data out still.
> > > >
> > > > Signed-off-by: Tom Rini <trini at konsulko.com>
> > > > ---
> > > >  test/py/tests/test_ut.py | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > Reviewed-by: Simon Glass <sjg at chromium.org>
> > >
> > > I wonder if these ever actually succeed later on, or do they remain
> > > mounted forever?
> >
> > They complete the unmount with this change done, yes.
> 
> That's great to hear. I wonder if we should try a 'sync' beforehand?
> So long as it is short it shouldn't matter, but if it dragged on for a
> minute or two it might conflict with another job.  I don't have a good
> understanding of what is going on in the kernel.

Based on a quick read of the man page, I think --lazy itself is just
what we want here.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230407/f9867163/attachment.sig>


More information about the U-Boot mailing list