Aw: [v1 1/2] board: mediatek: add Bananapi-R3 devicetree

Frank Wunderlich frank-w at public-files.de
Sat Apr 8 09:37:52 CEST 2023


Hi

noticed that i need to change the label of wps button back to "wps" when enabling the factory
button (else there will be 2 buttons with same label).

> Gesendet: Freitag, 07. April 2023 um 23:26 Uhr
> Von: "Frank Wunderlich" <linux at fw-web.de>
> Betreff: [v1 1/2] board: mediatek: add Bananapi-R3 devicetree
>
> From: Daniel Golle <daniel at makrotopia.org>
>
> Add board specific devicetree for Bananapi R3 SBC.
>
> Signed-off-by: Daniel Golle <daniel at makrotopia.org>
> Signed-off-by: Frank Wunderlich <frank-w at public-files.de>
> ---
> taken from openwrt
> https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=package/boot/uboot-mediatek/patches/430-add-bpi-r3.patch;hb=HEAD
> only enabled the factory button which was disabled because a HW-bug in
> rev 1.0 of r3.
> ---
> diff --git a/arch/arm/dts/mt7986a-bpi-r3-sd.dts b/arch/arm/dts/mt7986a-bpi-r3-sd.dts
> new file mode 100644
> index 000000000000..82a3975c7de8
> --- /dev/null
> +++ b/arch/arm/dts/mt7986a-bpi-r3-sd.dts

> +	keys {
> +		compatible = "gpio-keys";
> +
> +		factory {
> +			label = "reset";
> +			gpios = <&gpio 9 GPIO_ACTIVE_LOW>;
> +		};
> +
> +		wps {
> +			label = "reset";

label was changed in openwrt to use this button for reset, but hw bug fixed in newer v1.1 versions of
the board. I will change this to "wps" like in linux in next version.

just tell me if the structure is right or if there any other things need to be changed.

> +			gpios = <&gpio 10 GPIO_ACTIVE_LOW>;
> +		};
> +	};

regards Frank


More information about the U-Boot mailing list