[PATCH] i2c: designware_i2c: remove apparently redundant read of 'i2c,speeds' DT property
Heiko Schocher
hs at denx.de
Tue Apr 11 12:58:47 CEST 2023
Hello Rasmus,
On 24.03.23 09:09, Rasmus Villemoes wrote:
> This code first figures out if there is an i2c,speeds property, if so
> its size in u32s, and then reads the value into the local speeds[]
> array. Both 'size' and 'speeds' are completely unused thereafter.
>
> It's not at all clear what this is supposed to do. Of course, it could
> be seen as a sanity check that the DT node does have an i2c,speeds
> property with an appropriate number of elements, but for that one
> wouldn't actually need to read it into speeds[]. Also, I can't find
> anywhere else in the U-Boot code which makes use of values from that
> property (this is is the only C code referencing "i2c,speeds"), so it
> seems pointless to insist that it's there.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes at prevas.dk>
> ---
> drivers/i2c/designware_i2c_pci.c | 14 --------------
> 1 file changed, 14 deletions(-)
Applied to u-boot-i2c.git master
Thanks!
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs at denx.de
More information about the U-Boot
mailing list