[PATCH 0/8] Add ESM support for J721E and J7200

[Andrew Davis]

On 4/11/23 4:21 AM, Neha Malcom Francis wrote:
> Hi Bryan
> 
> On 10/04/23 20:09, Bryan Brattlof wrote:
>> Hi Neha!
>>
>> On April 10, 2023 thus sayeth Neha Malcom Francis:
>>> Add support for ESM (Error Signalling Module) in J721E and J7200. The
>>> ESM error pin output is routed to the PMIC (Power Management IC) which
>>> can reset the board. The dts nodes for SoC and PMIC ESM modules are
>>> added (if not already) to enable them.
>>>
>>> Gowtham Tammana (6):
>>>    arm: dts: k3-j7200: Add Main domain ESM support
>>>    arm: dts: k3-j7200-r5-common: Add pmic node for esm
>>>    arm: dts: k3-j7200: Add ESM PMIC support for tps659413
>>>    j721e_init: initialize ESM support for J7200 SOM
>>>    power: pmic: tps65491: Dont fail on master node
>>>    configs: j7200_evm_r5_defconfig: Enable ESM modules
>>>
>>> Tero Kristo (2):
>>>    arm: mach-k3: j721e_init: initialize ESM support
>>>    arm: dts: k3-k721e: Add Main domain ESM support
>>>
>>>   .../k3-j7200-common-proc-board-u-boot.dtsi    |  4 +++
>>>   arch/arm/dts/k3-j7200-main.dtsi               |  6 +++++
>>>   .../k3-j7200-r5-common-proc-board-u-boot.dtsi | 11 ++++++++
>>>   .../arm/dts/k3-j7200-r5-common-proc-board.dts | 13 +++++++---
>>>   arch/arm/dts/k3-j7200.dtsi                    |  1 +
>>>   arch/arm/dts/k3-j721e.dtsi                    |  1 +
>>>   arch/arm/mach-k3/j721e_init.c                 | 25 ++++++++++++++++++-
>>>   configs/j7200_evm_r5_defconfig                |  2 ++
>>>   drivers/power/pmic/tps65941.c                 |  1 -
>>>   9 files changed, 59 insertions(+), 5 deletions(-)
>>>   create mode 100644 arch/arm/dts/k3-j7200-r5-common-proc-board-u-boot.dtsi
>>>
>>
>> I know Praneeth and Andrew have already commented internally, I just
>> wanted to summarize publicly
>>
>> Thank you for sending this out! Unfortunately some of these dt node
>> updates where never sent to the kernel. We'll need to get these merged
>> over there so it will be a simple copy/paste once they make it to a
>> linux tag.
>>
>> Though I guess we can treat the dt updates as a DONOTMERGE
> 
> 
> Thanks for summarising! However I'm inclined to send a v2 of this patch series here without using board and SoC dts and using only -u-boot.dtsi since I do not think ESM support will be needed in the kernel at any point. What do you think?
> 

DT isn't concerned with who uses a node or not, it should be a universal description of the
hardware as it actually is. I know that isn't always the case today (GPU nodes *grumble*),
but it is still a goal. So if the ESM hardware exists in the chip, it should be described in
the DT file. If Linux/U-Boot/OPTEE/Zephyr/etc actually use the node for anything is up to
that piece of software.

Andrew

>>
>> ~Bryan
>